Remove "eager upgrade" from PROD image completely#33784
Merged
Conversation
potiuk
force-pushed
the
remove-eager-upgrade-from-dockerfile
branch
from
August 26, 2023 18:33
7c382af to
c2a54df
Compare
potiuk
force-pushed
the
remove-eager-upgrade-from-dockerfile
branch
from
August 26, 2023 19:43
c2a54df to
ad38876
Compare
There were still some left-overs of EAGER_UPGRADE in PROD image building. Howwever "eager upgrade" only makes sense for CI images. PROD images when being built should use eager upgrades as they are produced in the CI image step. This PR does the following: * removes eager upgrade parameters from PROD image * instead, prod image build has a new flag for installing the images: --use-constraints-for-context-packages which will automatically use constraints from "docker-context-files" if they are present there. * modifies the CI workflows to upload constraints as artifacts and download them for PROD image build when "eager upgrade" has been used and directs it to use "source" constraints * adds back support to "upgrade to newer dependencies" label that makes it easy to test "eager upgrade" As the result, when PROD image is build in CI: * when regular PR is run, it will use latest github "source" constraints * whwn "eager upgrade" PR is run, it will use the eager-upgrade constraints that were generated during CI build
potiuk
force-pushed
the
remove-eager-upgrade-from-dockerfile
branch
from
August 26, 2023 19:44
ad38876 to
a85cb5a
Compare
potiuk
requested review from
Taragolis,
eladkal,
ephraimbuddy and
hussein-awala
August 26, 2023 19:45
potiuk
marked this pull request as ready for review
August 26, 2023 19:45
Member
Author
|
This one should help PROD image to not fail (currently observed in 2-7-test branch - |
Member
Author
|
I also added back support for "upgrade to newer dependencies" label that makes it easier to test this case. |
Member
Author
|
All right. Seems it works. I tested it wiht both - regular case and "upgrade to newer dependencies" - we will need that one to cherry-pick it to 2-7 to make it green. |
hussein-awala
approved these changes
Aug 26, 2023
potiuk
added a commit
that referenced
this pull request
Aug 26, 2023
There were still some left-overs of EAGER_UPGRADE in PROD image building. Howwever "eager upgrade" only makes sense for CI images. PROD images when being built should use eager upgrades as they are produced in the CI image step. This PR does the following: * removes eager upgrade parameters from PROD image * instead, prod image build has a new flag for installing the images: --use-constraints-for-context-packages which will automatically use constraints from "docker-context-files" if they are present there. * modifies the CI workflows to upload constraints as artifacts and download them for PROD image build when "eager upgrade" has been used and directs it to use "source" constraints * adds back support to "upgrade to newer dependencies" label that makes it easy to test "eager upgrade" As the result, when PROD image is build in CI: * when regular PR is run, it will use latest github "source" constraints * whwn "eager upgrade" PR is run, it will use the eager-upgrade constraints that were generated during CI build (cherry picked from commit 2b1a194)
97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were still some left-overs of EAGER_UPGRADE in PROD image
building. Howwever "eager upgrade" only makes sense for CI images.
PROD images when being built should use eager upgrades as they
are produced in the CI image step.
This PR does the following:
the images: --use-constraints-for-context-packages which will
automatically use constraints from "docker-context-files" if
they are present there.
and download them for PROD image build when "eager upgrade"
has been used and directs it to use "source" constraints
that makes it easy to test "eager upgrade"
--build-progressflag to easier debug long buildsAs the result, when PROD image is build in CI:
constraints that were generated during CI build
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.