Fix cleaning zombie RESTARTING tasks#33706
Merged
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
2 tasks
Bisk1
force-pushed
the
fix-zombie-restarting
branch
from
August 24, 2023 19:56
96ef98c to
8399582
Compare
Member
|
As discussed in the issue #33706 - that sounds good. But I would love others who know more about inricacise of executors might chime in ? :D |
potiuk
approved these changes
Aug 24, 2023
ephraimbuddy
approved these changes
Aug 24, 2023
added 2 commits
August 24, 2023 23:55
Renamed to adoptable_states because adoption is preferrable choice and reset is fallback. Also "resettable" might be confused with RESTARTING itself.
hussein-awala
approved these changes
Aug 24, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Fix cleaning zombie RESTARTING tasks * Fix test * Improve naming Renamed to adoptable_states because adoption is preferrable choice and reset is fallback. Also "resettable" might be confused with RESTARTING itself. --------- Co-authored-by: daniel.dylag <danieldylag1990@gmail.com> (cherry picked from commit 5c35786)
97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #33661
Added
RESTARTINGstate to the list of task instance states that are handled by scheduler inadopt_or_reset_orphaned_tasks(). This way the system can recover from the situation when a task was set toRESTARTINGstate externally (webserver request) but both task process and scheduler were dead when it happened.This approach is safe because
adopt_or_reset_orphaned_tasks()only modifies tasks that were queued by a scheduler that is no longer running. In theory it could reset a task which is still running even though its scheduler is dead, but it is identical situation as withRUNNINGtasks which are also updated by this method.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.