Bind engine before attempting to drop archive tables#33622
Merged
Conversation
potiuk
approved these changes
Aug 22, 2023
Member
|
Thanks @SamWheating ! |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 911cf46)
97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #33606
It looks like we weren't properly binding the engine to the table object before attempting to drop it, and as a result SQLalchemy was throwing exceptions. The only tests which actually run the db cleanup had set
skip_archive=Falseso this went through undetected.Anyways, added a test to replicate the issue and then fixed it.