make conf.set case insensitive#33452
Merged
Merged
Conversation
`conf.get` is insensitive (it converts section and key to lower case) but set is not, which can lead to surprising behavior (see the test, which is not passing without the fix). I suggest that we override set as well to fix that. Any value that was set before with upper case was unreacheable.
syedahsn
reviewed
Aug 16, 2023
uranusjr
reviewed
Aug 17, 2023
Lee-W
reviewed
Aug 17, 2023
Lee-W
left a comment
Member
There was a problem hiding this comment.
I like this change. I remember I encountered such a gotcha recently. But have the same questions/suggestions as TP
hussein-awala
approved these changes
Aug 17, 2023
hussein-awala
left a comment
Member
There was a problem hiding this comment.
LGTM after resolving the discussions with the other reviewers.
potiuk
approved these changes
Aug 18, 2023
potiuk
left a comment
Member
There was a problem hiding this comment.
Same as @hussein-awala. OK for me with a few small comments
Taragolis
approved these changes
Aug 21, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
* make `conf.set` case insensitive `conf.get` is insensitive (it converts section and key to lower case) but set is not, which can lead to surprising behavior (see the test, which is not passing without the fix). I suggest that we override set as well to fix that. Any value that was set before with upper case was unreacheable. * fix remove_option as well * away with the str() * add significant change newsfragment (cherry picked from commit abbd567)
97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conf.getis insensitive (it converts section and key to lower case), butsetis not, which can lead to surprising behavior (see the test, which is not passing without the fix).I suggest that we override set as well to fix that. Any value that was set before with upper case was unreacheable.