Ensure the KPO runs pod mutation hooks correctly#31173
Merged
jedcunningham merged 1 commit intoapache:mainfrom May 9, 2023
Merged
Ensure the KPO runs pod mutation hooks correctly#31173jedcunningham merged 1 commit intoapache:mainfrom
jedcunningham merged 1 commit intoapache:mainfrom
Conversation
If you run a task via the cli with `cfg_path`, we also run `configure_vars` again so that the globals built from the config file can be updated. We were also initializing pluggy in that function, however, which was effectively removing any user provided hooks. We will move the initializing of pluggy out of that function, making it safe to run again by the task command.
Member
Author
|
I decided not to write a test for this, I think the likelihood of a regression here is pretty small. |
dstandish
approved these changes
May 9, 2023
ashb
approved these changes
May 9, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
May 10, 2023
If you run a task via the cli with `cfg_path`, we also run `configure_vars` again so that the globals built from the config file can be updated. We were also initializing pluggy in that function, however, which was effectively removing any user provided hooks. We will move the initializing of pluggy out of that function, making it safe to run again by the task command. This primarily impacted KPOs, as they wouldn't have been passed through any `pod_mutation_hooks`. (cherry picked from commit 71c2627)
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run a task via the cli with
cfg_path, we also runconfigure_varsagain so that the globals built from the config file can be updated. We were also initializing pluggy in that function, however, which was effectively removing any user provided hooks.We will move the initializing of pluggy out of that function, making it safe to run again by the task command.
This primarily impacted KPOs, as they wouldn't have been passed through any
pod_mutation_hooks.