Skip to content

Improve task group UI in new graph#30918

Merged
bbovenzi merged 2 commits intoapache:mainfrom
astronomer:graph-ui-adjustments
Apr 27, 2023
Merged

Improve task group UI in new graph#30918
bbovenzi merged 2 commits intoapache:mainfrom
astronomer:graph-ui-adjustments

Conversation

@bbovenzi
Copy link
Copy Markdown
Contributor

@bbovenzi bbovenzi commented Apr 27, 2023

  • Add a background opacity to task groups
  • Increase the touch area for the expand/collapse button on a task group

Screenshot 2023-04-27 at 3 03 12 PM

Screenshot 2023-04-27 at 3 03 25 PM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added the type:bug-fix Changelog: Bug Fixes label Apr 27, 2023
@bbovenzi bbovenzi added this to the Airflow 2.6.1 milestone Apr 27, 2023
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 27, 2023
@bbovenzi bbovenzi mentioned this pull request Apr 27, 2023
6 tasks
@bbovenzi bbovenzi marked this pull request as ready for review April 27, 2023 19:02
@bbovenzi bbovenzi merged commit de0cdd7 into apache:main Apr 27, 2023
@bbovenzi bbovenzi deleted the graph-ui-adjustments branch April 27, 2023 20:40
@set92
Copy link
Copy Markdown

set92 commented Apr 27, 2023

Yes, looks clearer now 😄. Now it's easier to differentiate between a task and a Taskgroup.
I still think that is annoying the position of the text to open the Taskgroup, but is true that there isn't a better place. A coworker told me it was better for it to be on the left side because that way you don't need to move around to close it, but then the left side would have too many things. Although, it is true that I had a fun thought of an animated accordion moving the name of the Taskgroup to the right while opening. But I'm a random DE who doesn't know much about UI/UX, better listen to your guts or what other experienced guys say 😀.

I suppose having colors for each task could also be useful, specially with many tasks in a Taskgroup. E.g. Finding a random Operator between plenty of python Operators, can be hard since all have the same white background.

Another function related to Taskgroups that I don't know if it is working as intended is the clears. For example, if you filter upstream to see better some part of a DAG, and then want to clear some tasks, I see 3 possible options:

  • Clear from some task to the end of DAG.
  • Clear from some task to the end of its Taskgroup.
  • Clear from some task to the end of what he sees on screen (the filtered DAG).

Right now is working as case 1, not sure whether it would make sense (or how easy is) to implement the other 2.

ephraimbuddy pushed a commit that referenced this pull request May 8, 2023
* Improve task group UI in new graph

* adjust task group color

(cherry picked from commit de0cdd7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants