Fix dynamic imports in google ads vendored in library#30468
Conversation
ad432cf to
7cd47ca
Compare
ashb
left a comment
There was a problem hiding this comment.
Skimmed only (assuming it's automated)
|
We still need to get confirmation it actually works :) @collinmcnulty |
|
We have not seen this resolve the problem yet. I'm double checking that the patched code is what's running before ringing alarm bells. |
|
Hi @potiuk @collinmcnulty, we are able to test this branch successfully for google ads api. Eager to have this provider published soon. Test steps: |
WOOOOOOHOOOOO!!!! Let me then rebase the PR to succeed and we might want to release an ad-hoc release of Google Provider @eladkal ! Happy to do it as well if you want. |
I will do it today |
|
I have to close that PR and open a new one to make it from the "apache/airflow" repository - there is a change in "breeze" that will only work when merged to main or when the PR is run from "apache/airflow" repo, so in order to test it, I need to recreate it. |
|
New PR opened in #30544 |


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.