Reenable clear on TaskInstanceModelView for role User#30415
Merged
potiuk merged 5 commits intoapache:mainfrom Apr 22, 2023
Merged
Reenable clear on TaskInstanceModelView for role User#30415potiuk merged 5 commits intoapache:mainfrom
potiuk merged 5 commits intoapache:mainfrom
Conversation
e561cd2 to
53f3b5f
Compare
Contributor
|
If we're going to reenable clear, we will also want to reenable |
added 2 commits
April 12, 2023 10:30
The action was disable in apache#20659 which resolved apache#20655. The issue only mentions that the edit is broken and should be disabled. So it seem like the disabling of the clear action was unintentional. Also based on the discussion in the PR apache#20655 further reinforces this. That the author believed it still worked could be explain by that using a user with role `Admin` the action was still available and therefore one could easily make a mistake believing it still worked as expected. This PR reenables it action and modifies and existing test case to also verify that clearing is possible using a user with the role `User`.
53f3b5f to
fe22c1a
Compare
Author
Added back all the |
bbovenzi
approved these changes
Apr 13, 2023
eladkal
reviewed
Apr 17, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2023
* Reenable clear on TaskInstanceModelView for role User The action was disable in #20659 which resolved #20655. The issue only mentions that the edit is broken and should be disabled. So it seem like the disabling of the clear action was unintentional. Also based on the discussion in the PR #20655 further reinforces this. That the author believed it still worked could be explain by that using a user with role `Admin` the action was still available and therefore one could easily make a mistake believing it still worked as expected. This PR reenables it action and modifies and existing test case to also verify that clearing is possible using a user with the role `User`. * Add back other set state actions * fix static checks --------- Co-authored-by: eladkal <45845474+eladkal@users.noreply.github.com> (cherry picked from commit b140c44)
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action was disable in #20659 which resolved #20655. The issue only mentions that the edit is broken and should be disabled. So it seem like the disabling of the clear action was unintentional.
Also based on the discussion in the PR #20655 further reinforces this. That the author believed it still worked could be explain by that using a user with role
Adminthe action was still available and therefore one could easily make a mistake believing it still worked as expected.This PR reenables it action and modifies and existing test case to also verify that clearing is possible using a user with the role
User.This closes #30414