Rename JobRunner modules to *_job_runner and base_job* to job#30302
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 10, 2023
Merged
Rename JobRunner modules to *_job_runner and base_job* to job#30302potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
Based on #30255, so please check only the last commit. |
This was referenced Mar 26, 2023
ff62bc7 to
b5fe668
Compare
This was referenced Mar 27, 2023
b5fe668 to
2d9ebfd
Compare
potiuk
commented
Apr 9, 2023
airflow/models/__init__.py
Outdated
Member
Author
There was a problem hiding this comment.
Not needed any more - theose are not polymorphic an do not need to be registered at init.
dc3e7c9 to
4a18d1c
Compare
Member
Author
|
Now - this one is pure rename of the modules + claass names to reflect the refactoring from #30255:
|
4a18d1c to
6bacc03
Compare
Member
Author
|
This one should be super-easy to review :) |
uranusjr
reviewed
Apr 10, 2023
7e8d971 to
d76aa13
Compare
uranusjr
reviewed
Apr 10, 2023
d76aa13 to
30cad5e
Compare
jedcunningham
approved these changes
Apr 10, 2023
The apache#30255 introduced "JobRunner" concept and decoupled the job logic from the ORM polymorphic *Job objects. The change was implemented in the way to minimise the review effort needed, so it avoided renaming the modules for the runners (from `_job` to `_job_runner`). Also BaseJob lost its "polymorphism" properties so the package, and class name can be renamed to simply job. This PR completes the JobRunner concept introduction by applying the renames. Closes: apache#30296
1db3239 to
e785922
Compare
2 tasks
This was referenced May 13, 2023
6 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #30255 introduced "JobRunner" concept and decoupled the job logic
from the ORM polymorphic *Job objects. The change was implemented
in the way to minimise the review effort needed, so it avoided renaming
the modules for the runners (from
_jobto_job_runner).Also BaseJob lost its "polymorphism" properties so the package, and class name
can be renamed to simply job.
This PR completes the JobRunner concept introduction by applying the
renames.
Closes: #30296
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.