Add CloudSQLCloneInstanceOperator#29726
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
tests/static checks are failing |
| "airflow.providers.google.cloud.operators.vertex_ai.endpoint_service.UpdateEndpointOperator", | ||
| "airflow.providers.google.cloud.operators.vertex_ai.batch_prediction_job." | ||
| "GetBatchPredictionJobOperator", | ||
| "airflow.providers.google.cloud.operators.cloud_sql.CloudSQLCloneInstanceOperator", |
There was a problem hiding this comment.
What is the motivation to add new operator without example?
Is there a difficulty in creating the example dag?
Out goal is to reduce this list not to make it bigger.
There was a problem hiding this comment.
Good point. Thank you for the hint. I updated the associated example DAG to demonstrate usage of the CloudSQLCloneInstanceOperator.
There was a problem hiding this comment.
Great. We are almost there. The example was created but it is not referenced in the docs so users can't find it.
See our docs https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/cloud_sql.html
You need to add a short description in the docs and refer to the example you wrote.
The relevant file to edit is:
https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-google/operators/cloud/cloud_sql.rst
There was a problem hiding this comment.
all right. Thank you for pointing me to the right files. I updated the PR accordingly.
CloudSQLCloneInstanceOperator
|
@FloMom static checks are failing :( |
faa6f98 to
91d7860
Compare
91d7860 to
14fc75c
Compare
|
Awesome work, congrats on your first merged pull request! |
Created CloudSQLCloneInstanceOperator to provide a simple way of cloning a cloudSQL instance from a DAG.
It is making use of google's instance.clone method as described here: https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1/instances/clone