Skip to content

Migrated operators tests to pytest - #29377

Merged
Taragolis merged 8 commits into
apache:mainfrom
Abhishek-kumar-ISM:migrating_operators_tests_to_pytest
Feb 17, 2023
Merged

Migrated operators tests to pytest#29377
Taragolis merged 8 commits into
apache:mainfrom
Abhishek-kumar-ISM:migrating_operators_tests_to_pytest

Conversation

@Abhishek-kumar-ISM

@Abhishek-kumar-ISM Abhishek-kumar-ISM commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

Migrated some tests/operators to pytest

related: #29305

@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 5, 2023

Copy link
Copy Markdown
Contributor Author

@Taragolis migrated operators tests to pytest.

Can you please review.

@Taragolis Taragolis added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:misc/internal Changelog: Misc changes that should appear in change log labels Feb 7, 2023
@Taragolis Taragolis changed the title Migrated operators tests to pytest Migrated email and generic transfer operators tests to pytest Feb 7, 2023
@Taragolis Taragolis mentioned this pull request Feb 7, 2023
Closed
13 tasks
@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 9, 2023

Copy link
Copy Markdown
Contributor Author

@Taragolis when an approved PR is finally merged by those who have write access?
when all checks pass?

@potiuk

potiuk commented Feb 9, 2023

Copy link
Copy Markdown
Member

In general yes - there was some problem in this case with available built images (something to solve separately). I rerun it and sometime after tests are all green we merge it (if you notice we did not - ping us).

@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 9, 2023

Copy link
Copy Markdown
Contributor Author

@potiuk thankyou, i had one more PR related with the same issue.
#29373
which was also approved, can you re run that also?

@eladkal

eladkal commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

i had one more PR related with the same issue. #29373 which was also approved, can you re run that also?

rebase triggers new test run (I did it for the PR)

@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 9, 2023

Copy link
Copy Markdown
Contributor Author

Okay thankyou.

@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Taragolis migrated all tests/operators tests to pytest. Please check

To handle subTests i have used @pytest.mark.parametrize to run all tests using pytest.mark arguments, instead of looping and testing using subTest as pytest does not have subTest.

@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Taragolis @potiuk @eladkal all checks are passed.
Please review and merge the PR.

Taragolis
Taragolis requested changes Feb 16, 2023
View reviewed changes
Comment thread tests/operators/test_datetime.py Outdated
Comment thread tests/operators/test_datetime.py Outdated
Comment thread tests/operators/test_datetime.py Outdated
Comment thread tests/operators/test_datetime.py Outdated
@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

@Taragolis done changes, as requested by you.

@Taragolis

Taragolis commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

I will have a look later.

Seem like that all operators tests migrated to pytest if so, could you also change a PR name?

@Abhishek-kumar-ISM Abhishek-kumar-ISM changed the title Migrated email and generic transfer operators tests to pytest Migrated operators tests to pytest Feb 16, 2023
@Abhishek-kumar-ISM

Abhishek-kumar-ISM commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

I will have a look later.

Seem like that all operators tests migrated to pytest if so, could you also change a PR name?

Done

@Taragolis
Taragolis merged commit 73c8e7d into apache:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes
@Taragolis Taragolis Taragolis approved these changes

Assignees

No one assigned

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Abhishek-kumar-ISM @potiuk @eladkal @Taragolis