migrated some part of test always to pytest

[Abhishek-kumar-ISM]

Migrated some part of tests/always to pytest

related: #29305

[Abhishek-kumar-ISM]

@Taragolis migrated some tests/always to pytest.

Please review.

[Taragolis]

You could check previous PR with migration always to pytest. Potentially you could find useful information here

[Abhishek-kumar-ISM]

@Taragolis ok i will try to see.
Actually tests/always has two files which need to be migrated to pytest.
In one file they are using self.subTest which was giving me problem while migrating, and other file in @parameterized.expand a function was passed which was giving some problem to me while migrating.

So i converted only a part of tests/always.

But i will try to cover other left part also.

[Taragolis]

In one file they are using self.subTest which was giving me problem while migrating,

As far as I remember:

1. In always subtest is useless and could be replaced by regular assert. And this test is broken and always success
2. In operators subtest also broken (do not cleanup stage between subtest run). In general all subtest could be rewrited by parametrised tests (@pytest.mark.parametrize)

So i converted only a part of tests/always.

No problem, there is no target to do everything in one go

[Taragolis]

However still better to fix at list one module 😉

[Abhiaps]

In one file they are using self.subTest which was giving me problem while migrating,

As far as I remember:

1. In always subtest is useless and could be replaced by regular assert. And this test is broken and always success
2. In operators subtest also broken (do not cleanup stage between subtest run). In general all subtest could be rewrited by parametrised tests (@pytest.mark.parametrize)

So i converted only a part of tests/always.

No problem, there is no target to do everything in one go

😊Okay i will try

[Abhishek-kumar-ISM]

@Taragolis migrated all tests/always files to pytest.

I didn't find any alternative of mock objects of unittest, so i haven't done anything with mock objects of unittest,

Only changed @parameterized.expand to @pytest.mark.parametrize, changed subtest to some alternative and other small changes.

[Abhishek-kumar-ISM]

@Taragolis @potiuk @eladkal all checks have passed.

Please review.

[potiuk]

Hmm. That looks strange. I am not sure if I understand why we have try/Except at all (assert with description should be enough) and I am not sure what was the effect of self.subTest here. Can you please explain @Abhishek-kumar-samsung ?

[Abhishek-kumar-ISM]

I explained just below.

[potiuk]

I see. Makes sense for subtest removal.

But why not just this:

assert set() == missing_tests_files, "Detect missing tests in providers module"

[Abhishek-kumar-ISM]

I didn't knew if it can be done that way, i knew try except way, and tried testing by putting missing_tests_files as none, try except way was working fine so i kept that.
And also as per understanding, try except was much easy to understand.

[Abhishek-kumar-ISM]

if you want, i can try your way @potiuk.

[Abhishek-kumar-ISM]

oh okay, i will modify it.

[potiuk]

And no. For me in this case try/except is actually confusing, because it makes the person reading it to think "is there any reason why this is done this way? Did I miss something?".

[Abhishek-kumar-ISM]

@potiuk done as you have said.

[Taragolis]

Just for a record this test was broken before, and missing_tests_files always empty set.

[potiuk]

Well.. :)

[Abhiaps]

@potiuk Actually as per what I read subTest can be used if we need to do multiple tests with varying arguments. But here it was just a single test which can be written via simple assert only.

So I am not sure why they used subTest here.
In one more PR in which I migrated tests/operator test functions, there were several uses of subTest which makes a lot of sense, there they used for loop to create several subTests with varying arguments.

But here I don't think it makes much sense of writing subTest if we can simply write assert.

Just above in this PR only @Taragolis also commented that here subTest is useless and can be easily replaced by regular assert.

[Abhishek-kumar-ISM]

@potiuk i have added the changes as you have requested, and it is working fine, checks are also passed.