Skip to content

migrating from unittest to pytest tests cli file #29354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taragolis merged 3 commits into from
Feb 3, 2023
Merged

migrating from unittest to pytest tests cli file #29354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf5772f
migrating from unittest to pytest tests cli file
Feb 3, 2023
59a5a32
made changes to parameterized expand in one cli test file
Feb 3, 2023
bbd7249
removed unused imports
Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions tests/cli/commands/test_pool_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import io
import json
import os
import unittest
from contextlib import redirect_stdout

import pytest
Expand All @@ -33,17 +32,14 @@
from airflow.utils.db import add_default_pool_if_not_exists


class TestCliPools(unittest.TestCase):
class TestCliPools:
@classmethod
def setUpClass(cls):
def setup_class(cls):
cls.dagbag = models.DagBag(include_examples=True)
cls.parser = cli_parser.get_parser()

def setUp(self):
super().setUp()
settings.configure_orm()
self.session = Session
self._cleanup()
cls.session = Session
cls._cleanup()

def tearDown(self):
self._cleanup()
Expand Down
12 changes: 6 additions & 6 deletions tests/cli/commands/test_task_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

import pendulum
import pytest
from parameterized import parameterized

from airflow import DAG
from airflow.cli import cli_parser
Expand Down Expand Up @@ -336,12 +335,13 @@ def test_cli_test_with_env_vars(self):
assert "foo=bar" in output
assert "AIRFLOW_TEST_MODE=True" in output

@parameterized.expand(
@pytest.mark.parametrize(
"option",
[
("--ignore-all-dependencies",),
("--ignore-depends-on-past",),
("--ignore-dependencies",),
("--force",),
"--ignore-all-dependencies",
"--ignore-depends-on-past",
"--ignore-dependencies",
"--force",
],
)
def test_cli_run_invalid_raw_option(self, option: str):
Expand Down