Skip to content

Add dep context description for better log message #28875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstandish merged 1 commit into from
Jan 12, 2023
Merged

Add dep context description for better log message #28875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion airflow/models/taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ def are_dependencies_met(
if failed:
return False

verbose_aware_logger("Dependencies all met for %s", self)
verbose_aware_logger("Dependencies all met for dep_context=%s ti=%s", dep_context.description, self)
return True

@provide_session
Expand Down Expand Up @@ -1245,6 +1245,7 @@ def check_and_change_state_before_execution(
ignore_depends_on_past=ignore_depends_on_past,
wait_for_past_depends_before_skipping=wait_for_past_depends_before_skipping,
ignore_task_deps=ignore_task_deps,
description="non-requeueable deps",
)
if not self.are_dependencies_met(
dep_context=non_requeueable_dep_context, session=session, verbose=True
Expand Down Expand Up @@ -1274,6 +1275,7 @@ def check_and_change_state_before_execution(
wait_for_past_depends_before_skipping=wait_for_past_depends_before_skipping,
ignore_task_deps=ignore_task_deps,
ignore_ti_state=ignore_ti_state,
description="requeueable deps",
)
if not self.are_dependencies_met(dep_context=dep_context, session=session, verbose=True):
self.state = State.NONE
Expand Down
1 change: 1 addition & 0 deletions airflow/ti_deps/dep_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ class DepContext:
ignore_ti_state: bool = False
ignore_unmapped_tasks: bool = False
finished_tis: list[TaskInstance] | None = None
description: str | None = None

have_changed_ti_states: bool = False
"""Have any of the TIs state's been changed as a result of evaluating dependencies"""
Expand Down