Skip to content

New AWS sensor — DynamoDBValueSensor#28338

Merged
potiuk merged 34 commits into
apache:mainfrom
mrichman:main
Apr 14, 2023
Merged

New AWS sensor — DynamoDBValueSensor#28338
potiuk merged 34 commits into
apache:mainfrom
mrichman:main

Conversation

@mrichman

Copy link
Copy Markdown
Contributor

DynamoDBValueSensor waits for an attribute value to be present for an item in a DynamoDB table.

@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Dec 13, 2022
@boring-cyborg

boring-cyborg Bot commented Dec 13, 2022

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@mrichman

Copy link
Copy Markdown
Contributor Author

@o-nikolas Please review at your convenience. Thanks.

@ferruzzi

Copy link
Copy Markdown
Contributor

This is marked as a draft, do you want a review on it or are you still working on it?

Comment thread airflow/providers/amazon/aws/example_dags/example_dynamodb_sensor.py Outdated
@mrichman

Copy link
Copy Markdown
Contributor Author

@ferruzzi Yes please review. @o-nikolas suggested I create as a draft to limit visibility. Thanks!

Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py Outdated
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py Outdated
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py Outdated
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py Outdated
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py Outdated
@o-nikolas

Copy link
Copy Markdown
Contributor

Hey @mrichman,

Any plans to make more progress on this one?

@mrichman

Copy link
Copy Markdown
Contributor Author

@o-nikolas Yes indeed, just haven't come up for air with all my new customers. It's definitely toward the top of my (ever growing) todo list.

@mrichman
mrichman marked this pull request as ready for review January 27, 2023 21:21
@mrichman
mrichman requested a review from Taragolis January 28, 2023 01:42
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py Outdated

@ferruzzi ferruzzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two non-blocking ideas. Once the tests pass, I'm happy to approve.

Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py
Comment thread airflow/providers/amazon/aws/sensors/dynamodb.py Outdated
@mrichman

mrichman commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

@ferruzzi Am I to use tests/providers/amazon/aws/providers for my unit test?

@eladkal

eladkal commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

@ferruzzi Am I to use tests/providers/amazon/aws/providers for my unit test?

It should be in
tests/providers/amazon/aws/sensors/test_dynamodb.py

If file doesn't exist then create it.

@ferruzzi

ferruzzi commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

What Elad said 😄

Basically just replace the airflow in the file's path with tests so tests for airflow/providers/amazon/aws/sensors/test_dynamodb.py go in tests/providers/amazon/aws/sensors/test_dynamodb.py

Comment thread dags/example_dynamodb.py Outdated
Comment thread dags/example_dynamodb.py Outdated
Comment thread docs/apache-airflow-providers-amazon/operators/dynamodb.rst Outdated

@ferruzzi ferruzzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.

@o-nikolas o-nikolas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I just triggered another build, if it goes green I'll merge :)

@mrichman

Copy link
Copy Markdown
Contributor Author

image

@o-nikolas

Copy link
Copy Markdown
Contributor

Just approved another build on the latest changes! 🤞

@potiuk
potiuk merged commit 9666178 into apache:main Apr 14, 2023
@boring-cyborg

boring-cyborg Bot commented Apr 14, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ferruzzi

Copy link
Copy Markdown
Contributor

Nice, congrats!

@potiuk

potiuk commented Apr 14, 2023

Copy link
Copy Markdown
Member

Indeed.

@o-nikolas

Copy link
Copy Markdown
Contributor

congrats on the first contribution @mrichman!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants