Skip to content

[AIRFLOW-1692] Changed test_views filename#2673

Closed
NielsZeilemaker wants to merge 1 commit into
apache:masterfrom
NielsZeilemaker:AIRFLOW-1692
Closed

[AIRFLOW-1692] Changed test_views filename#2673
NielsZeilemaker wants to merge 1 commit into
apache:masterfrom
NielsZeilemaker:AIRFLOW-1692

Conversation

@NielsZeilemaker

Copy link
Copy Markdown
Contributor

to support windows

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    The test_views unit-test used a file which contained colons. Such a file is not supported on windows.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io

codecov-io commented Oct 7, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2673   +/-   ##
=======================================
  Coverage   71.68%   71.68%           
=======================================
  Files         154      154           
  Lines       11808    11808           
=======================================
  Hits         8465     8465           
  Misses       3343     3343
Impacted Files Coverage Δ
airflow/models.py 87.09% <0%> (-0.05%) ⬇️
airflow/executors/dask_executor.py 81.39% <0%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2078dac...a35a4fd. Read the comment docs.

@Fokko

Fokko commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

+1 Let the tests pass on Windows

@NielsZeilemaker

Copy link
Copy Markdown
Contributor Author

Not really, as the unit-tests don't run on windows. But, it will allow me to do a git checkout on windows.

@andyxhadji

Copy link
Copy Markdown
Contributor

LGTM - Can we merge this? It'll unblock #2532!

@NielsZeilemaker

Copy link
Copy Markdown
Contributor Author

@bolkedebruin would it be possible to merge this pull request?

asfgit pushed a commit that referenced this pull request Oct 18, 2017
Closes #2673 from NielsZeilemaker/AIRFLOW-1692

(cherry picked from commit 2da4856)
Signed-off-by: Bolke de Bruin <bolke@xs4all.nl>
@asfgit asfgit closed this in 2da4856 Oct 18, 2017
@bolkedebruin

Copy link
Copy Markdown
Contributor

Done sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants