[AIRFLOW-1692] Changed test_views filename#2673
Closed
NielsZeilemaker wants to merge 1 commit into
Closed
Conversation
to support windows
Codecov Report
@@ Coverage Diff @@
## master #2673 +/- ##
=======================================
Coverage 71.68% 71.68%
=======================================
Files 154 154
Lines 11808 11808
=======================================
Hits 8465 8465
Misses 3343 3343
Continue to review full report at Codecov.
|
4 tasks
Contributor
|
+1 Let the tests pass on Windows |
Contributor
Author
|
Not really, as the unit-tests don't run on windows. But, it will allow me to do a git checkout on windows. |
Contributor
|
LGTM - Can we merge this? It'll unblock #2532! |
Contributor
Author
|
@bolkedebruin would it be possible to merge this pull request? |
asfgit
pushed a commit
that referenced
this pull request
Oct 18, 2017
Closes #2673 from NielsZeilemaker/AIRFLOW-1692 (cherry picked from commit 2da4856) Signed-off-by: Bolke de Bruin <bolke@xs4all.nl>
Contributor
|
Done sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to support windows
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
The test_views unit-test used a file which contained colons. Such a file is not supported on windows.
Tests
Commits