Resolve deprecation warning re Table.exists()#26616
Merged
Merged
Conversation
Member
|
I think so, we are now requiring |
uranusjr
approved these changes
Sep 23, 2022
dstandish
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
September 23, 2022 06:24
uranusjr
approved these changes
Sep 23, 2022
ephraimbuddy
approved these changes
Sep 23, 2022
Member
|
Need to fix compat shim usages in migration files |
The deprecation warning tells us we need to change Table.exists() to Inspector.has_table(). It turns out we're already using the right method, but we weren't passing it the right object. It wants a table name but we were giving it a table.
dstandish
force-pushed
the
fix-has_table-warning
branch
from
September 23, 2022 07:45
ff8fca7 to
fb27a44
Compare
potiuk
approved these changes
Sep 23, 2022
jedcunningham
approved these changes
Sep 23, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
The deprecation warning tells us we need to change Table.exists() to Inspector.has_table(). It turns out we're already using the right method, but we weren't passing it the right object. It wants a table name but we were giving it a table. (cherry picked from commit 2388bd7)
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecation warning tells us we need to change Table.exists() to Inspector.has_table(). It turns out we're already using the right method, but we weren't passing it the right object. It wants a table name but we were giving it a table.
@uranusjr do you think it's safe to remove the compat layer altogether?