Skip to content

For worker log servers only bind to IPV6 when dual stack is available #26222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 3 commits into from
Sep 8, 2022
Merged

For worker log servers only bind to IPV6 when dual stack is available #26222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a4a388
Only server to IPV6 when dual stack is confirmed
notatallshaw-gts Sep 7, 2022
8bde54e
Update airflow/utils/serve_logs.py
ashb Sep 8, 2022
5e5cb8d
Update airflow/utils/serve_logs.py
ashb Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions airflow/utils/serve_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import collections
import logging
import os
import socket

import gunicorn.app.base
from flask import Flask, abort, request, send_from_directory
Expand Down Expand Up @@ -143,13 +144,14 @@ def serve_logs():

worker_log_server_port = conf.getint('logging', 'WORKER_LOG_SERVER_PORT')

# Make sure to have both an IPv4 and an IPv6 interface.
# Gunicorn can bind multiple addresses, see https://docs.gunicorn.org/en/stable/settings.html#bind.
options = [
GunicornOption("bind", f"0.0.0.0:{worker_log_server_port}"),
GunicornOption("bind", f"[::]:{worker_log_server_port}"),
GunicornOption("workers", 2),
]
# If dual stack is available and IPV6_V6ONLY is not enabled on the socket
# then when IPV6 is bound to it will also bind to IPV4 automatically
if getattr(socket, "has_dualstack_ipv6", lambda: False)():
bind_option = GunicornOption("bind", f"[::]:{worker_log_server_port}")
else:
bind_option = GunicornOption("bind", f"0.0.0.0:{worker_log_server_port}")

options = [bind_option, GunicornOption("workers", 2)]
StandaloneGunicornApplication(wsgi_app, options).run()


Expand Down