[AIRFLOW-1571] Add AWS Lambda Hook#2570
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2570 +/- ##
==========================================
+ Coverage 71.13% 71.14% +<.01%
==========================================
Files 150 150
Lines 11741 11741
==========================================
+ Hits 8352 8353 +1
+ Misses 3389 3388 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
can we textwrap.dedent here instead
There was a problem hiding this comment.
thanks @saguziel for reviewing my PR :) Pushed the change.
|
@artwr @criccomini (+ @saguziel @bolkedebruin) seems like you guys reviewed similar AWS related PR - #1630 Would be great if you could help review my PR. Any inputs are welcome (this is my first contribution to airflow) :) |
|
Please make sure your commits are merged into one. |
1c92785 to
8be60fd
Compare
|
@bolkedebruin resolved commits. thanks |
71fb066 to
91c6845
Compare
There was a problem hiding this comment.
You need some :paramname: and :type: documentation for the Class docstring, for the constructor properties
e.g.
:param function_name: The name of the AWS Lambda function to call
:type function_name: string
etc
There was a problem hiding this comment.
Looking through the contrib codebase I see a lot of missing docstrings and param info, which is a shame because it's then missing when generating the docs, so maybe I will contribute to improving that.
But generally I can't see any other issues with the code, so it's a great effort! At some point soon I will be using your dynamodb stuff heavily, so if it's not in a release by then I will borrow it for my plugins folder 😀
There was a problem hiding this comment.
thanks @davoscollective for all the positive energy :)
e2bbbba to
6a96caf
Compare
fb7fb12 to
c542b9c
Compare
8b5de04 to
d448b18
Compare
|
Closing this PR - its a duplicate of #2718 |
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Details of this PR are in the Jira above.
Tests
This unit test uses moto to mock aws lambda. Firstly, we create a lambda function (assuming this function is already created by aws cloudformation template in production). Secondly, we trigger lambda function using invoke function in the hook. Lastly, we parse the response and assert statements.
Commits