Remove Smart Sensors - #25507
Merged
Merged
Conversation
ashb
requested review from
XD-DENG,
bbovenzi,
ephraimbuddy,
jedcunningham,
kaxil,
mik-laj,
potiuk and
ryanahamilton
as code owners
August 3, 2022 11:16
ashb
force-pushed
the
remove-smart-sensors
branch
2 times, most recently
from
August 3, 2022 11:17
bcb4e7a to
3f48a5a
Compare
potiuk
reviewed
Aug 3, 2022
potiuk
left a comment
Member
There was a problem hiding this comment.
Another -1700 lines of code :)
eladkal
reviewed
Aug 3, 2022
eladkal
left a comment
Contributor
There was a problem hiding this comment.
There are some more refrences in docs:
sensors.rst:
deferring.rst:
It was deprecated in 2.3 and since it is experimental we can now remove it -- Deferrable operators is a much more efficient pattern to achieve the same feature.
ashb
force-pushed
the
remove-smart-sensors
branch
from
August 4, 2022 13:36
566d0ed to
bc9c9d7
Compare
jedcunningham
approved these changes
Aug 4, 2022
This was referenced Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was deprecated in 2.3 and since it is experimental we can now remove
it -- Deferrable operators is a much more efficient pattern to achieve
the same feature.