Skip to content

Remove Werkzeug limitation after flask-login was fixed #25291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 27, 2022
Merged

Remove Werkzeug limitation after flask-login was fixed #25291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ install_requires =
# for example any new methods, are accounted for.
flask-appbuilder==4.1.3
flask-caching>=1.5.0
flask-login>=0.5
flask-login>=0.6.2
flask-session>=0.4.0
flask-wtf>=0.15
graphviz>=0.12
Expand Down Expand Up @@ -149,9 +149,7 @@ install_requires =
termcolor>=1.1.0
typing-extensions>=4.0.0
unicodecsv>=0.14.1
# werkzeoug 2.2.0 breaks flask-login. see https://github.com/maxcountryman/flask-login/issues/686 for details.
# we need werkzeug<2.2 limitation until flask_login are handle it
werkzeug>=2.0,<2.2
werkzeug>=2.0

[options.packages.find]
include =
Expand Down
5 changes: 3 additions & 2 deletions tests/www/views/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# specific language governing permissions and limitations
# under the License.
import os
import re
from typing import Callable
from unittest import mock

Expand Down Expand Up @@ -375,7 +376,7 @@ def test_get_task_stats_from_query():
assert data == expected_data


INVALID_DATETIME_RESPONSE = "Invalid datetime: &#x27;invalid&#x27;"
INVALID_DATETIME_RESPONSE = re.compile(r"Invalid datetime: &#x?\d+;invalid&#x?\d+;")


@pytest.mark.parametrize(
Expand Down Expand Up @@ -432,4 +433,4 @@ def test_invalid_dates(app, admin_client, url, content):
resp = admin_client.get(url, follow_redirects=True)

assert resp.status_code == 400
assert content in resp.get_data().decode()
assert re.search(content, resp.get_data().decode())