Fix Grid vertical scrolling#24684
Merged
Merged
Conversation
pierrejeambrun
approved these changes
Jun 27, 2022
this should be done in a separate PR
bbovenzi
force-pushed
the
fix-grid-scroll
branch
from
June 28, 2022 15:01
6f4cdd1 to
88ec3e2
Compare
ashb
approved these changes
Jun 28, 2022
Merged
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 30, 2022
* fix vertical scrolling * fix flex grow for panel open/close * add type checking * add duration axis component * remove details/grid width changes this should be done in a separate PR (cherry picked from commit 1429091)
This was referenced Jul 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had 2 issues with grid scrolling for large DAGs:
This PR moves
position: stickyto the table header cells to fix this. Also, upgraded any affected files to typescript.Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.