Do not calculate grid root instances#24528
Merged
Merged
Conversation
ashb
reviewed
Jun 17, 2022
| return { | ||
| 'id': task_group.group_id, | ||
| 'children': children, | ||
| 'instances': [], |
Member
There was a problem hiding this comment.
Will not having label here confuse your Typescript changes in the UI?
ashb
approved these changes
Jun 17, 2022
ashb
left a comment
Member
There was a problem hiding this comment.
You may need to correct the tests too 😁
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 30, 2022
* do not calculate grid root instances * fix tests (cherry picked from commit 8b054ef)
This was referenced Jul 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were calculating
instancesfor the root ofgrid_databut we didn't use that information for anything. Instead we should detect when it is the root node and only return what is necessary^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.