Expose device_requests to DockerOperator - Enable GPU support#21974
Expose device_requests to DockerOperator - Enable GPU support#21974TediPapajorgji wants to merge 6 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
just fixed tests, my apologies |
|
Please fix the static check failures. |
|
Yep. I recommend to install pre-commit. |
Hey guys i'll do this today. |
|
@TediPapajorgji you will need also to rebase and resolve conflicts |
|
@eladkal done! |
|
Also - the updates to Changelog are not needed (and a bit harmful). The decision of version bump and changelog are generated (semi-automatically) by the release manager when the provider is released so please remove it from this change. |
|
Hi Team, How can I update this version of docker? |
|
@wcwt this PR wasn't merged it. @TediPapajorgji can you revert changes to |
Yep I'll do it today. |
|
Also if possible to add a unit test / add coverage for this change in an existed test. test_execute_with_device_requests?
|
|
Some conflicts are there as well |
|
@TediPapajorgji I'd be happy to merge this PR once issues are fixed. |
|
@TediPapajorgji could you please check the fail tests? , I really need your changes . |
|
@danycohensa you can checkout @TediPapajorgji branch and re PR the fix (thus it will still give credit to the original author). |
|
Closing in favor of #23554 |
|
@eladkal when the next release with updated DockerOperator is planned? |
|
@happyhooter RC already cut |
This PR adds the ability to pass
device_requeststo the DockerOperator during initialization. This is useful for enabling GPU support in the DockerOperator.This also opens the door to exposing all other host resources to the docker container.
As an example, with this change, here is how one could expose all GPU's on the host machine to the docker container:
closes: #9492