Dispose not used connection pool#21565
Merged
Merged
Conversation
KevinYang21
approved these changes
Feb 14, 2022
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ashb
approved these changes
Feb 14, 2022
pingzh
force-pushed
the
pingzh-dispose-orm
branch
from
February 14, 2022 21:26
182a8d7 to
41a9c1e
Compare
jedcunningham
approved these changes
Feb 15, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 23, 2022
(cherry picked from commit 8155e8a)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 8155e8a)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
(cherry picked from commit 8155e8a)
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
task_run, it has to dispose the ORM then configure orm, otherwise, the existing db connection won't be closed. When there are lots of running tasks, the DB is likely to get connection error.Test:
before the change
i put a
time.sleep(1000)right after thesettings.configure_orm(disable_connection_pool=True)After the change
i put a
time.sleep(1000)right after thesettings.reconfigure_orm(disable_connection_pool=True)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.