Log traceback in trigger excs#21213
Merged
Merged
Conversation
malthe
requested review from
XD-DENG,
ashb,
dstandish and
kaxil
as code owners
January 29, 2022 21:19
malthe
force-pushed
the
log-traceback-in-trigger-excs
branch
2 times, most recently
from
January 30, 2022 08:48
ea75bb1 to
08e020f
Compare
uranusjr
approved these changes
Jan 31, 2022
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
reviewed
Jan 31, 2022
dstandish
requested changes
Jan 31, 2022
uranusjr
approved these changes
Feb 3, 2022
dstandish
approved these changes
Feb 3, 2022
Member
|
Can you please rebase @malthe - we fixed a few issues in main. |
malthe
force-pushed
the
log-traceback-in-trigger-excs
branch
from
February 6, 2022 20:16
c891e10 to
e0ca3e0
Compare
malthe
force-pushed
the
log-traceback-in-trigger-excs
branch
from
February 9, 2022 06:30
e0ca3e0 to
98ca266
Compare
Contributor
Author
|
@eladkal got time to check up on this one? |
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 20, 2022
(cherry picked from commit 4ad21f5)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 4ad21f5)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 4ad21f5)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 4ad21f5)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 4ad21f5)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 4ad21f5)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
(cherry picked from commit 4ad21f5)
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an exception is raised in a triggerer job during (asynchronous) execution of a trigger, the exception is logged locally, but the traceback is not sent to the task log. Instead, the fail-handler simply logs a message that the trigger has failed.
With the suggested change, the formatted traceback is persisted in the task instance and included as part of a logging line when the task resumes to handle the failure.