Check next run exists before reading data interval - #19307
Conversation
400376c to
5761ee3
Compare
| pytest.param( | ||
| DEFAULT_DATE, | ||
| DEFAULT_DATE, | ||
| DEFAULT_DATE + timedelta(days=1), |
There was a problem hiding this comment.
for the modern case, your explicit data interval and the schedule interval are both 1 day. so it's sortof ambiguous what's driving the result (i.e. is it cus of the data interval you provided, or because of the schedule interval?). seems it might be better to choose an interval that differs from the schedule interval of the dag, to make it clearer.
There was a problem hiding this comment.
Good point. It is logically not possible for a DAG to return different data intervals via inference and explicit timetable (for obvious reasons), but it is a good way to test the behaviour in a unit test.
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
) Fix apache#19304, and also an issue on scheduling a DAG's first-ever run introduced in apache#18897. We could fix it outside this function, but if `next_dagrun` is None, the next run's data interval is supposed to be None in the first place, so checking inside this function just makes sense. closes apache#19343 closes apache#19304 (cherry picked from commit dc4dcaa)
) Fix apache#19304, and also an issue on scheduling a DAG's first-ever run introduced in apache#18897. We could fix it outside this function, but if `next_dagrun` is None, the next run's data interval is supposed to be None in the first place, so checking inside this function just makes sense. closes apache#19343 closes apache#19304 (cherry picked from commit dc4dcaa)
Fix #19304, and also an issue on scheduling a DAG's first-ever run introduced in #18897. We could fix it outside this function, but if `next_dagrun` is None, the next run's data interval is supposed to be None in the first place, so checking inside this function just makes sense. closes #19343 closes #19304 (cherry picked from commit dc4dcaa)
Fix #19304, and also an issue on scheduling a DAG's first-ever run introduced in #18897. We could fix it outside this function, but if `next_dagrun` is None, the next run's data interval is supposed to be None in the first place, so checking inside this function just makes sense. closes #19343 closes #19304 (cherry picked from commit dc4dcaa)
|
Is there a possible window of time when this is going to be released? We have the same problem in our Environment and discuss if we downgrade or wait for this fix. |
|
No hard timeline, it all depends on how the release can be properly tested and vetted. See #19558 for latest update. |
|
Airflow 2.2.2 has now been released that contains this fix. @en1cc |
Fix #19304, and also an issue on scheduling a DAG's first-ever run introduced in #18897. We could fix it outside this function, but if
next_dagrunis None, the next run's data interval is supposed to be None in the first place, so checking inside this function just makes sense.closes #19343
closes #19304