Fix MySQL db migration with default encoding/collation - #19268
Conversation
A check in |
Yup, a separate PR though |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
Agree. Checking it (incliding providing instructions on how to fix it) before migration is a very good idea (and agree with @kaxil it should be separate PR). |
|
Jeez. I hate MySQL. |
potiuk
left a comment
There was a problem hiding this comment.
Good to go but. Should be rebased - we have the "migration" check to make sure that rebase happens for any migration changes (just to make sure we do not get into "double migration HEADs" state).
efe2626 to
edff7c1
Compare
edff7c1 to
c91ce46
Compare
(cherry picked from commit e76a69b)
This allows the migrations to complete for MySQL db's without proper encoding/collation defaults.
I almost feel that we should be blocking migrations from running if they aren't set properly? Thoughts?
Related: #18939