Skip to content

Fix MySQL db migration with default encoding/collation - #19268

Merged
jedcunningham merged 1 commit into
apache:mainfrom
astronomer:mysql_migrations
Oct 28, 2021
Merged

Fix MySQL db migration with default encoding/collation#19268
jedcunningham merged 1 commit into
apache:mainfrom
astronomer:mysql_migrations

Conversation

@jedcunningham

Copy link
Copy Markdown
Member

This allows the migrations to complete for MySQL db's without proper encoding/collation defaults.

I almost feel that we should be blocking migrations from running if they aren't set properly? Thoughts?

Related: #18939

Comment thread airflow/migrations/versions/7b2661a43ba3_taskinstance_keyed_to_dagrun.py Outdated
@uranusjr

Copy link
Copy Markdown
Member

I almost feel that we should be blocking migrations from running if they aren't set properly?

A check in upgradedb feels like a good idea to me.

@kaxil

kaxil commented Oct 28, 2021

Copy link
Copy Markdown
Member

A check in upgradedb feels like a good idea to me.

Yup, a separate PR though

@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 28, 2021
@potiuk

potiuk commented Oct 28, 2021

Copy link
Copy Markdown
Member

Agree. Checking it (incliding providing instructions on how to fix it) before migration is a very good idea (and agree with @kaxil it should be separate PR).

@potiuk

potiuk commented Oct 28, 2021

Copy link
Copy Markdown
Member

Jeez. I hate MySQL.

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go but. Should be rebased - we have the "migration" check to make sure that rebase happens for any migration changes (just to make sure we do not get into "double migration HEADs" state).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants