Skip to content

Use gettempdir, respecting tempdir enviroment variables - #19209

Closed
aran3 wants to merge 1 commit into
apache:mainfrom
aran3:gettempdir
Closed

Use gettempdir, respecting tempdir enviroment variables#19209
aran3 wants to merge 1 commit into
apache:mainfrom
aran3:gettempdir

Conversation

@aran3

@aran3 aran3 commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

closes: #19206
Use tempfile.gettempdir() to get temp directory path, respecting TMPDIR and other standard environment variables - for creating the webserver cache, and also sqlite default location.
This is backward-compatible: if no special environment variable is set - it defaults to /tmp.

@boring-cyborg boring-cyborg Bot added the area:webserver Webserver related Issues label Oct 25, 2021
@boring-cyborg

boring-cyborg Bot commented Oct 25, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@aran3

aran3 commented Oct 25, 2021

Copy link
Copy Markdown
Contributor Author

Closing pull-request, as #19208 with the same fix by @potiuk

@aran3 aran3 closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webserver uses /tmp and does not respect user-configured tempdir path

1 participant