Updating Amazon-AWS example DAGs to use XComArgs#16868
Merged
potiuk merged 2 commits intoJul 26, 2021
Merged
Conversation
josh-fell
force-pushed
the
xcomarg-update-example-dags-amazon
branch
from
July 21, 2021 17:42
4ac5efd to
a46b530
Compare
kaxil
reviewed
Jul 21, 2021
josh-fell
force-pushed
the
xcomarg-update-example-dags-amazon
branch
from
July 26, 2021 14:11
cb374b5 to
79cbf56
Compare
potiuk
approved these changes
Jul 26, 2021
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
nathadfield
pushed a commit
to king/airflow
that referenced
this pull request
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #10285
xcom_pull()calls use an operator's.outputproperty as well access ofTaskInstanceobjects from context to useget_current_context()functionXComArgsfor transparencydefault_argspattern where necessary as requested by @ashb (i.e. removed a separateddefault_argsdeclaration for deference for declaration as part of theDAGobject)An detailed summary of all changes made as part of this PR can be found below:
xcom_pull()?XComArgs.Refactored
default_argspattern.default_argspattern.XComArgs.Refactored
default_argspattern.XComArgobject does not support accessing specific values of an iterableXComvalue elegantly. Did not update this occurrence:"{{ task_instance.xcom_pull(task_ids='add_steps', key='return_value')[0] }}".All other
xcom_pull()calls have been updated.Removed explicit task dependencies that are created via
XComArgs.Refactored
default_argspattern.XComArgobject does not support accessing specific values of an iterableXComvalue. Could not update any occurrences in this DAG.XComArgs.Updated to use
get_current_context().^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.