Use SimpleTaskInstance for multiprocessing in CeleryExecutor#16231
Closed
mik-laj wants to merge 1 commit into
Closed
Use SimpleTaskInstance for multiprocessing in CeleryExecutor#16231mik-laj wants to merge 1 commit into
mik-laj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.queued_taskscontainsOrderedDict[TaskInstanceKey, QueuedTaskInstanceType]objects whereQueuedTaskInstanceTypeis defined asTuple[CommandType, int, Optional[str], TaskInstance].airflow/airflow/executors/base_executor.py
Line 63 in 29409ac
airflow/airflow/executors/base_executor.py
Line 42 in 29409ac
airflow/airflow/executors/base_executor.py
Line 164 in 29409ac
Unfortunately, we were reading the values and writing them to the variable
simple_ti, but it's not valid. It should beti.airflow/airflow/executors/celery_executor.py
Line 252 in 29409ac
airflow/airflow/executors/celery_executor.py
Line 257 in 29409ac
I also confirmed it via the ipdb.
Sending TI by multiprocessing sometimes fails because TaskInstance is not always properly serialized
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.