Feature: Auto-refresh Graph view chart - #11534
Merged
Merged
Conversation
Member
|
This is awesome 🚀 |
Member
|
Is it worth removing the opacity overlay when refreshing too? |
Contributor
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
ryanahamilton
force-pushed
the
graph_auto_refresh
branch
from
October 14, 2020 22:14
ba923d9 to
f443f3b
Compare
Contributor
Author
|
@ashb I refactored it a bit in this PR… Previously the containing gray box had its opacity reduced and it was a bit janky when paired with the GIF overlay. I updated it so that just the SVG element within the gray box had its opacity reduced more subtly when updating (it looks smoother IRL than the PR GIF). |
dimberman
self-requested a review
October 14, 2020 23:30
dimberman
approved these changes
Oct 14, 2020
dimberman
left a comment
Contributor
There was a problem hiding this comment.
God I am so f-ing ready for this 🍾
ashb
reviewed
Oct 15, 2020
ashb
reviewed
Oct 15, 2020
ashb
reviewed
Oct 15, 2020
ryanahamilton
force-pushed
the
graph_auto_refresh
branch
from
October 15, 2020 12:41
f443f3b to
a73e7db
Compare
kaxil
approved these changes
Oct 15, 2020
ashb
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localStorageand will be "off" for any subsequent visits to the Graph view of this and any other DAG.In action:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.