Skip to content

Change prefix of Aws dynamodb hook file#11209

Merged
ashb merged 7 commits into
apache:masterfrom
eladkal:aws_dynamodb
Oct 11, 2020
Merged

Change prefix of Aws dynamodb hook file#11209
ashb merged 7 commits into
apache:masterfrom
eladkal:aws_dynamodb

Conversation

@eladkal

@eladkal eladkal commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

Removing aws_ prefix from aws_dynamodb.py to allign with the rest of AWS hook files.

@boring-cyborg boring-cyborg Bot added the provider:amazon AWS/Amazon - related issues label Sep 30, 2020
@eladkal eladkal changed the title Aws dynamodb Change prefix of Aws dynamodb hook file Sep 30, 2020
@eladkal
eladkal force-pushed the aws_dynamodb branch 2 times, most recently from b6cf5d5 to 788b92f Compare October 3, 2020 07:17
Comment thread tests/test_project_structure.py Outdated

@turbaszek turbaszek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need change also here

(
'airflow.providers.amazon.aws.hooks.aws_dynamodb.AwsDynamoDBHook',
'airflow.contrib.hooks.aws_dynamodb_hook.AwsDynamoDBHook',
),

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@ashb ashb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, then LGTM

Comment thread airflow/providers/amazon/aws/ADDITIONAL_INFO.md Outdated
@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@eladkal

eladkal commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

I'm not sure what is the issue with the black static test. It doesnt happen on my local fork.

@eladkal
eladkal requested review from ashb and turbaszek October 6, 2020 12:12
@turbaszek

Copy link
Copy Markdown
Member

@eladkal please rebase, what command are you running locally to check the files?

Comment thread airflow/providers/amazon/aws/hooks/aws_dynamodb.py Outdated
Comment thread tests/deprecated_classes.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't have a deprecation mechanism between backport package versions, right? Only between Airflow 1.10.x and latest backport packages.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create a followup task for that

@feluelle

feluelle commented Oct 8, 2020

Copy link
Copy Markdown
Member

@ashb want to have a look again? The small comment has been resolved.

@eladkal

eladkal commented Oct 11, 2020

Copy link
Copy Markdown
Contributor Author

hi @ashb rebased again if you can take another look

@ashb
ashb merged commit c3e3405 into apache:master Oct 11, 2020
@eladkal
eladkal deleted the aws_dynamodb branch October 12, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants