Add template fields renderers for better UI rendering - #11061
Merged
Conversation
Member
Author
This PR adds posibility to define template_fields_renderers for an operator. In this way users will be able to provide information what lexer should be used for rendering particular field. This is super useful for custom operator and gives more flexibility than predefined keywords.
turbaszek
force-pushed
the
add-operator-renderers
branch
from
September 21, 2020 20:41
a99aab1 to
7460984
Compare
olchas
reviewed
Sep 22, 2020
olchas
reviewed
Sep 22, 2020
olchas
reviewed
Sep 22, 2020
Co-authored-by: Kamil Olszewski <34898234+olchas@users.noreply.github.com>
turbaszek
marked this pull request as ready for review
September 22, 2020 10:37
houqp
approved these changes
Sep 22, 2020
feluelle
reviewed
Sep 23, 2020
Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
Member
Author
|
@feluelle can you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds possibility to define template_fields_renderers for an
operator. In this way, users will be able to provide information
on what lexer should be used for rendering a particular field. This is
super useful for custom operator and gives more flexibility than
predefined keywords.
Before
After
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.