Use inclusive words in Apache Airflow project

[turbaszek]

Description

Apache Software Foundation is discussing how we can improve inclusiveness of projects and raise awareness of conscious language. Related thread on diversity@a.o:
https://lists.apache.org/thread.html/r2d8845d9c37ac581046997d980464e8a7b6bffa6400efb0e41013171%40%3Cdiversity.apache.org%3E

Use case / motivation

We already have pre-commit check that checks for some word. However, on CLC (Conscious Language Checker) Apache Airflow seems to have problems with the following words:

• he
• her
• him
• his
• master
• sanity check
• slave
• whitelist (pylintrc)

Are you willing to submit a PR?

Related Issues

#12982 #9175

[turbaszek]

CC @leahecole

[leahecole]

Love it. A couple of clarifying questions

• If I'm understanding correctly, the pre commit check is preventing the introduction of new instances of these words, but these are the words we have that were already in? (legacy non-inclusive words, I suppose? 😁 )
• Is this issue to go through and remove said words, or to introduce more automation?

[turbaszek]

• If I'm understanding correctly, the pre commit check is preventing the introduction of new instances of these words, but these are the words we have that were already in? (legacy non-inclusive words, I suppose? 😁 )

That's one reason. The other one is that #12982 is still opened. Also I some words cannot be removed because are used by 3rd party tools

• Is this issue to go through and remove said words, or to introduce more automation?

Both, when we remove the word we should add it to existing rule or create new one similar to this:

airflow/.pre-commit-config.yaml

Lines 333 to 341 in 476d0f6

	- id: language-matters
	language: pygrep
	name: Check for language that we do not accept as community
	description: Please use "deny_list" or "allow_list" instead.
	entry: "(?i)(black|white)[_-]?list"
	pass_filenames: true
	exclude: >
	(?x)
	^airflow/providers/apache/cassandra/hooks/cassandra\.py$|

[Patil2099]

I would love to take this up @turbaszek

[turbaszek]

@Patil2099 I assigned you to this ticket 👏

[Patil2099]

I am not an expert with regular expression. Can you help me with the regular expression? @turbaszek

[turbaszek]

I am not an expert with regular expression. Can you help me with the regular expression? @turbaszek

Sure, what we would like to check? What words?

[Patil2099]

Sorry for the late reply, I have to edit the regex in pre-commit to solve this issue right? @turbaszek. I have to exclude all the words right? mentioned in #15994 (comment). I need a little help in that.

[ktmud]

Thanks for taking on this! Is there any chance that DummyOperator can be renamed to something else, too? I've heard dummy may be a non-inclusive word, too.

[turbaszek]

Sorry for the late reply, I have to edit the regex in pre-commit to solve this issue right? @turbaszek. I have to exclude all the words right? mentioned in #15994 (comment). I need a little help in that.

@Patil2099 yes, we should add similar hook to pre-commit-config as this one:

airflow/.pre-commit-config.yaml

Lines 333 to 341 in 476d0f6

	- id: language-matters
	language: pygrep
	name: Check for language that we do not accept as community
	description: Please use "deny_list" or "allow_list" instead.
	entry: "(?i)(black|white)[_-]?list"
	pass_filenames: true
	exclude: >
	(?x)
	^airflow/providers/apache/cassandra/hooks/cassandra\.py$|

The regexp should be like (?i)(\bmaster\b|\bhe\b|\bshe\b|\bhis\b|\bher\b) so we match exact word not substrings like HElp.
Also we will need to adjust all occurrences of non-inclusive words.

Thanks for taking on this! Is there any chance that DummyOperator can be renamed to something else, too? I've heard dummy may be a non-inclusive word, too.

@ktmud that's interesting suggestion. This would be a breaking change but I think it's worth trying. Any suggestions for a new name? CC @leahecole @kaxil @potiuk