Modified Monitor to always show table structure#6401
Merged
Conversation
This change modifies the Monitor to always show the structure of the tables on the page, even if they are empty.
* remove stale comments from manager.js * avoiding hiding running compactions page by default * clear running compactions page when manager is down and skip updating it
DomGarguilo
approved these changes
May 29, 2026
dlmarion
commented
May 29, 2026
| refreshManagerStatus().then(function (managerStatus) { | ||
| // tables will not be shown, avoid reloading | ||
| if (managerStatus === 'ERROR') { | ||
| runningTable.clear().draw(); |
Contributor
Author
There was a problem hiding this comment.
why clear this table? The compactors would still run compactions even if the Manager is down. Is there an error in collecting this information from the Compactors when the Manager is down?
Member
There was a problem hiding this comment.
Yea I think I had the wrong idea on this. Just pushed 06af601 so that table's refresh status is not affected by the manager state.
Member
There was a problem hiding this comment.
And then realized we dont even need to be pulling the manager data in that method so cleaned that up in 4af6618.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the Monitor to always show the structure of the tables on the page, even if they are empty.