Refactors MultipleStoresIT#4975
Merged
Merged
Conversation
Refactors MultipleStoresIT to function more similarly to how other fate tests are run (the two store types are tested in their own separate concrete classes). Created MultipleStoresTestRunner which is very similar to FateTestRunner. MultipleStoresIT is now an abstract class implemented by two new classes MetaMultipleStoresIT and UserMultipleStoresIT. closes apache#4903
keith-turner
approved these changes
Oct 17, 2024
| import org.apache.accumulo.core.fate.zookeeper.ZooUtil; | ||
| import org.apache.zookeeper.KeeperException; | ||
|
|
||
| public interface MultipleStoresTestRunner { |
Contributor
There was a problem hiding this comment.
Could we remove this interface and move the methods it declares into MultipleStoresIT as abstract methods? No need to do that, just want to make sure I understand the structure of these changes. Wondering if this interface has any other purposes.
Member
Author
There was a problem hiding this comment.
yeah, not used anywhere else. Moved into MultipleStoresIT
|
|
||
| @BeforeAll | ||
| public static void setup() throws Exception { | ||
| SharedMiniClusterBase.startMiniCluster(); |
Contributor
There was a problem hiding this comment.
Why does mini cluster need to be started?
Member
Author
There was a problem hiding this comment.
It does not thanks for catching that. Meta and User shared the same setup before so splitting them up I must have carried this over unnecessarily. Removed it in eb74934
- Moves the methods from MultipleStoresTestRunner into MultipleStoresIT and removes MultipleStoresTestRunner - Removes unneccessary start of mini cluster in MetaMultipleStoresIT
Member
Author
|
@keith-turner Let me know if eb74934 looks good. I'll merge this in then |
keith-turner
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors MultipleStoresIT to function more similarly to how other fate tests are run (the two store types are tested in their own separate concrete classes). Created MultipleStoresTestRunner which is very similar to FateTestRunner. MultipleStoresIT is now an abstract class implemented by two new classes MetaMultipleStoresIT and UserMultipleStoresIT.
closes #4903