Add Balancer Metric for Migrations Needed #4699
Merged
Merged
Conversation
- Sorts and turns of formatting for meter exceptions in MetricsIT
Refactored the metric names for readability and added javadoc entries for each of the new balancer metrics
Count the latest in-progress migrations before calculating the total number of migrations
Produces a single metric for balancing that emits the current number of migrations needed for the system to be balanced. Switched metric to use a LongSupplier and handled the inital null condition.
ctubbsii
approved these changes
Jul 28, 2024
Member
ctubbsii
left a comment
There was a problem hiding this comment.
Seems fine if the ITs are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included changes from #4471. Reduced to a single balancer migrations metric.