WIP add reservation related metrics to scan server#4458
Closed
keith-turner wants to merge 2 commits into
Closed
Conversation
Scan servers differ from in tablet servers in that they can service scans for any tablet, but must read the tablets files and reserve those files to prevent the Accumulo GC from removing them. This happens the first time a tablet is read on a scan server and involves reads and writes to the metadata table. This PR is a start at adding metrics related to reservations so that is possible to have visibility into the impact of this process on scans.
Contributor
Author
|
Have not tested this yet, wanted to figure out the metrics for the tablet metadata cache before testing. Have a TODO in the PR about metrics for the cache. |
EdColeman
pushed a commit
to EdColeman/accumulo
that referenced
this pull request
Apr 16, 2024
, using the changes in apache#4459 as the base. includes updated documentation in MetricsProducer includes cache metrics for table metadata cache in sserver (resolves todo) These changes have not be test yet. These changes should not be merged until apache#4459 is complete.
Contributor
Author
|
closing in favor of #4461 |
Contributor
|
@keith-turner - did you mean to close this? |
EdColeman
added a commit
that referenced
this pull request
May 3, 2024
* Add scan server metrics * scan metrics renaming to remove specific service in favor of tags (removes tserver from scan metric names) * enable stats on scan sever tablet metadata cache * add resource.group to sserver common tags instead of on individual metrics --------- Co-authored-by: Keith Turner <kturner@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scan servers differ from in tablet servers in that they can service scans for any tablet, but must read the tablets files and reserve those files to prevent the Accumulo GC from removing them. This happens the first time a tablet is read on a scan server and involves reads and writes to the metadata table. This PR is a start at adding metrics related to reservations so that is possible to have visibility into the impact of this process on scans.