FateId to use UUID instead of long#4388
Merged
keith-turner merged 4 commits intoMar 16, 2024
Merged
Conversation
- FateId now uses a 128bit UUID instead of a (64bit) long - FateIds created by ZooStore and AccumuloStore now use a v4 UUID (random UUID) - FateIds created by FateIdGenerator now use a v3 UUID (name based) so the same FateKey gives the same UUID - Necessary updates to classes and tests which used the long id
Contributor
keith-turner
left a comment
There was a problem hiding this comment.
Still looking at this
keith-turner
approved these changes
Mar 16, 2024
Contributor
keith-turner
left a comment
There was a problem hiding this comment.
These changes look good, could not really review all the variable name changes which is why I asked if they were done w/ an ide. Would be good to add the unit test for illegal fate ids.
| FateInstanceType type = FateInstanceType.fromTableId(tid); | ||
| FateId fateId34L = FateId.from(type, 34L); | ||
| FateId fateId987L = FateId.from(type, 987L); | ||
| FateId fateId1 = FateId.from(type, UUID.randomUUID()); |
Contributor
There was a problem hiding this comment.
Were these test variable renames done using an ide?
Member
Author
There was a problem hiding this comment.
Yes, and I also double checked that the variables remained consistent
Contributor
|
I am going to open a follow on PR w/ the unit test changes I suggested |
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
Mar 16, 2024
keith-turner
added a commit
that referenced
this pull request
Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4277
Changes:
Note: