Globally Unique FATE Transaction Ids - Part 2#4228
Merged
keith-turner merged 5 commits intoFeb 5, 2024
Conversation
keith-turner
approved these changes
Feb 5, 2024
| try (LoadMappingIterator lmi = createLoadMappingIter(loadRanges)) { | ||
| var extent = | ||
| PrepBulkImport.validateLoadMapping("1", lmi, tabletIterFactory, maxTablets, 10001); | ||
| var extent = PrepBulkImport.validateLoadMapping("1", lmi, tabletIterFactory, maxTablets); |
Contributor
There was a problem hiding this comment.
Was 10001 just an unused method parameter? I thought I saw another place in the code where it was remove in the review.
Member
Author
There was a problem hiding this comment.
yes, validateLoadMapping() never used the transaction id
Contributor
|
@kevinrr888 I added a few comments and then committed this. Wanted to get it in since it was such a big change. |
This was referenced Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #4191 for #4044. This PR addresses the task "Change Repo to use FateId. Resolve issues stemming from these changes." This PR includes the following changes:
(72 file changes)
There are many places in the code marked "ELASTICITY_TODO DEFERRED - ISSUE 4044" which will be addressed in later PR(s)