adds support for compacting lots of tablets#3945
Merged
keith-turner merged 2 commits intoNov 27, 2023
Merged
Conversation
Removes buffering of all conditional results in memory in the compaction code. This allows compacting more tablets than would fit in memory. Changed the condition result BiConsumer to a Consumer because it was passing the extents twice, so a BiConsumer was not needed and made the code more verbose. Updated the compaction code to collect stats and log a trace. It was logging a lot of per tablet information at debug. When compacting one million tablets, this resulted in a lot of information in the manager logs. Moved the per tablet information to trace logging. Added collection of stats for the different per tablet information and logged the stats once for all tablets scanned. Added compaction to the SplitMillionIT. Without the other changes in this PR adding compaction to the SplitMillion would cause the Manager to die with an out of memory error because the conditional write was buffering all 1 million tablets.
8 tasks
8 tasks
dlmarion
reviewed
Nov 14, 2023
dlmarion
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes buffering of all conditional results in memory in the compaction code. This allows compacting more tablets than would fit in memory.
Changed the condition result BiConsumer to a Consumer because it was passing the extents twice, so a BiConsumer was not needed and made the code more verbose.
Updated the compaction code to collect stats and log a trace. It was logging a lot of per tablet information at debug. When compacting one million tablets, this resulted in a lot of information in the manager logs. Moved the per tablet information to trace logging. Added collection of stats for the different per tablet information and logged the stats once for all tablets scanned.
Added compaction to the SplitMillionIT. Without the other changes in this PR adding compaction to the SplitMillion would cause the Manager to die with an out of memory error because the conditional write was buffering all 1 million tablets.