Update TabletManagementIteratorIT for merge and wal checks#3923
Merged
Conversation
This updates tests in TabletManagementIteratorIT to verify that the iterator properly detects tablets needing attention if WALs exist on tablets that are part of a merge operation
keith-turner
approved these changes
Nov 6, 2023
Contributor
keith-turner
left a comment
There was a problem hiding this comment.
Would be nice to check split in addition to merge in the test.
Co-authored-by: Keith Turner <kturner@apache.org>
Contributor
Author
I added split as well on the latest update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates tests in
TabletManagementIteratorITto verify that the iterator properly detects tablets needing attention if WALs exist on tablets that are part of a merge operation. It also will test that if op type isDELETINGthat the tablet does not care if there are WALs.This PR only updates the tests in TabletManagementIteratorIT and doesn't try and do anything with TGW because after the refactoring in #3904 both the iterator and TGW share the same code for checking the goal state (where the WAL checks are done)
However, another possible follow on test improvement would be to create a test for the
TabletGoalStateclass where all the logic was refactored to inside of compute() to test the different cases for computing the resulting state. This could likely just be a normal unit test with mocking and not an IT.