adds support for splitting tablets with walogs#3914
Merged
Conversation
Updates the FATE operations that split tablets to handle walogs. These changes should wait for a tablet with walogs to recover before proceeding. The changes to actually make recovery happen were already done in apache#3904 with changes to TabletGoalState.compute(). This change is a WIP because it depends on apache#3847 and needs those changes to be complete. fixes apache#3844
Contributor
Author
|
Merged in elasticity with the changes from #3948 and can now take this out of draft. |
cshannon
reviewed
Dec 22, 2023
Contributor
cshannon
left a comment
There was a problem hiding this comment.
This looks good the only thing I noticed is I think we may be able to remove some of the validation checks now that seem redundant with conditional mutations such as in MergeTablets:
EdColeman
approved these changes
Feb 21, 2024
Contributor
Author
Those validations are still useful as they check the expected state when reading tablets in addition to when writing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the FATE operations that split tablets to handle walogs. These changes should wait for a tablet with walogs to recover before proceeding. The changes to actually make recovery happen were already done in #3904 with changes to TabletGoalState.compute(). This change is a WIP because it depends on #3847 and needs those changes to be complete.
fixes #3844