Cache existence of tablet directories in CompactionCoordinator#3583
Merged
dlmarion merged 5 commits intoJul 19, 2023
Conversation
Cache existence of tablet directories to avoid checking to see if they exist, which can be expensive. Fixes apache#3475
Contributor
keith-turner
left a comment
There was a problem hiding this comment.
Were you able to test this in any way? I suspect some of the volume related ITs may exercise the dir creation aspect of this, but not sure. Depends on if we have a multi volume IT that compacts data.
DomGarguilo
reviewed
Jul 10, 2023
Contributor
Author
No, I basically copied over the code from Tablet.java. I don't see any ITs that test this condition. It also looks like CompactionCoordinatorTest got nuked. Looking at the comment in that file, we might need a ticket to re-evaluate that |
keith-turner
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache existence of tablet directories to avoid checking to see if they exist, which can be expensive.
Fixes #3475