This now works with 1.27.1 along with AWS private files that require authentication.#1
Merged
antonydandrea merged 5 commits intoOct 28, 2016
Conversation
This reverts commit b0b1609.
…image table but not the actual file from S3.
Author
|
There are still a few tweaks but this version does work with AWS Private Files. A few more tweaks will be required to limit viewing access if not logged in. I will make those changes this week. |
Owner
|
Thanks kelvin, will review and merge in the next couple of days. Really appreciate this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still tweaking but I have tested and it is working locally on a fresh install.