CUDA: batch gate/up/down uploads for selected expert cache misses#460
Open
fmolara wants to merge 1 commit into
Open
CUDA: batch gate/up/down uploads for selected expert cache misses#460fmolara wants to merge 1 commit into
fmolara wants to merge 1 commit into
Conversation
When a selected expert cache miss occurs in the direct-I/O CUDA path, gate/up/down tensors are currently uploaded independently, synchronizing the selected upload stream after each tensor. Batch the three uploads for one expert and synchronize the upload stream once after all three have been enqueued. Layouts, cache policy and kernels are unchanged. Unsupported cases transparently fall back to the existing path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the CUDA direct-I/O path, a selected expert cache miss uploads the gate/up/down tensors independently, synchronizing the selected upload stream after each tensor.
This patch batches the three uploads belonging to the same expert and synchronizes the selected upload stream once after all three have been enqueued.
Properties
Validation