Add served model name option for server discovery#456
Open
RiccardoFiorentini wants to merge 1 commit into
Open
Add served model name option for server discovery#456RiccardoFiorentini wants to merge 1 commit into
RiccardoFiorentini wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #452.
ds4-servercurrently advertises fixed DeepSeek-compatible modelIDs from the discovery endpoints, which can collide with real cloud-provider IDs
in multi-provider clients.
Change
--served-model-name NAME.NAMEas non-empty and without/.GET /v1/models.GET /v1/models/<id>.Non-goals
modelvalidation or rewriting.Validation
Run on arm64 macOS 26.3 build 25D125, 32 GiB RAM, default Metal build.
Model/quant: not used.
make clean && make && make ds4_test && ./ds4_test --server— passed../ds4-server --help | rg -F -- '--served-model-name NAME'— passed.make ds4_test && ./ds4_test --server && git diff --check— passed during cleanup review.Also tried
make test: Q4K unit tests, extractor self-tests, and agent testspassed; the long-context stage stopped because
ds4flash.ggufis not present.No CUDA, ROCm, distributed, high-RAM, model-dependent inference, or performance
validation was run because this change is limited to server discovery metadata.