Conversation
HHVM dropped support for PHP at the end of 2018. While testing and basic support for HHVM was enabled in Patchwork, it has basically been broken since then and the tests aren't being run against HHVM anyway. So, let's formally drop support for it and remove all references to it. This commit actions this in the following manner: * Mark dedicated functions/classes related to HHVM as (soft) deprecated. * Remove all conditionals in the codebase related to HHVM. Follow-up actions: * I suggest opening an issue for `2.last` to hard deprecate the functions/classes (i.e. trigger a deprecation notice). * I also suggest opening an issue for 3.0 to remove the deprecated functions/classes. Ref: https://hhvm.com/blog/2017/09/18/the-future-of-hhvm.html Fixes 139
2bb74b4 to
a9a4589
Compare
Collaborator
|
Looks reasonable for what it does, and I agree with dropping HHVM. I'm less sure of the timeline though. The last version of HHVM that supported PHP was in 2018, which is the same age as PHP 7.2 which people out there are still using. I'd be more inclined to just deprecate here, and keep the conditionals too until 3.0. But that all depends on just how strictly we want to follow semver. |
Collaborator
Author
|
@anomiex It is unlikely that HHVM support still works at this time, so 🤷 |
antecedent
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HHVM dropped support for PHP at the end of 2018.
While testing and basic support for HHVM was enabled in Patchwork, it has basically been broken since then and the tests aren't being run against HHVM anyway.
So, let's formally drop support for it and remove all references to it.
This commit actions this in the following manner:
Follow-up actions:
2.lastto hard deprecate the functions/classes (i.e. trigger a deprecation notice).Ref: https://hhvm.com/blog/2017/09/18/the-future-of-hhvm.html
Fixes #139