Conversation
5 tasks
Collaborator
Author
|
@dipinknair @RobPasMue @SMoraisAnsys please review |
RobPasMue
approved these changes
Jan 15, 2025
Member
RobPasMue
left a comment
There was a problem hiding this comment.
Looks fine by me - but I may not be super proficient in the internals of what this implementation may cause as side effect
Member
|
Good thing is that it is an opt-in feature 😄 |
Collaborator
Author
I was planning to start by making it an opt-in feature for PyMechanical too. Maybe a kwarg in the App constructor. cc @dipinknair |
Member
Please do - let's not roll it out by default (yet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
C# naming conventions are different from python naming conventions. CamelCase is the usual convention for properties and methods in C#, while snake_case is preferred in python (pep8).
When using ansys-pythonnet to bind C# to python, python users will use the C# APIs with the C# conventions. This breaks expectations for python users.
This PR adds an option to enable pep8 aliases for python bindings, allowing python code to use pep8 even if the C# code does not.